Fokko commented on code in PR #7795:
URL: https://github.com/apache/iceberg/pull/7795#discussion_r1234123272
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -126,10 +126,13 @@ public FlinkCatalog(
@Override
public void open() throws CatalogException {
// Create the default database if it does not exist.
- try {
- createDatabase(getDefaultDatabase(), ImmutableMap.of(), true);
- } catch (DatabaseAlreadyExistException e) {
- // Ignore the exception if it's already exist.
+ String defaultDatabase = getDefaultDatabase();
+ if (!databaseExists(defaultDatabase)) {
+ try {
+ createDatabase(getDefaultDatabase(), ImmutableMap.of(), true);
+ } catch (DatabaseAlreadyExistException e) {
Review Comment:
Are you suggesting removing the create database call? The person that
initially reported this issue, was very supprised that this call was in there.
So I think that removing the call seems reasonable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
