stevenzwu commented on code in PR #7795:
URL: https://github.com/apache/iceberg/pull/7795#discussion_r1240425669
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -126,10 +126,13 @@ public FlinkCatalog(
@Override
public void open() throws CatalogException {
// Create the default database if it does not exist.
- try {
- createDatabase(getDefaultDatabase(), ImmutableMap.of(), true);
- } catch (DatabaseAlreadyExistException e) {
- // Ignore the exception if it's already exist.
+ String defaultDatabase = getDefaultDatabase();
+ if (!databaseExists(defaultDatabase)) {
+ try {
+ createDatabase(getDefaultDatabase(), ImmutableMap.of(), true);
+ } catch (DatabaseAlreadyExistException e) {
Review Comment:
@Fokko I am still leaning toward removing the create. This is a Flink
`Catalog` impl (not Iceberg catalog). I think we can stick with Flink
`HiveCatalog` style, where `open` method doesn't create the default database
automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
