rdblue commented on code in PR #6512:
URL: https://github.com/apache/iceberg/pull/6512#discussion_r1235503888
##########
core/src/main/java/org/apache/iceberg/rest/RESTSerializers.java:
##########
@@ -91,8 +94,12 @@ public static void registerAll(ObjectMapper mapper) {
.addDeserializer(
ImmutableReportMetricsRequest.class, new
ReportMetricsRequestDeserializer<>())
.addSerializer(CommitTransactionRequest.class, new
CommitTransactionRequestSerializer())
+ .addDeserializer(CommitTransactionRequest.class, new
CommitTransactionRequestDeserializer())
+ .addSerializer(RegisterTableRequest.class, new
RegisterTableRequestSerializer<>())
+ .addDeserializer(RegisterTableRequest.class, new
RegisterTableRequestDeserializer<>())
Review Comment:
Why do we register both the interface and the implementation? Shouldn't we
just need one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
