rdblue commented on code in PR #6512:
URL: https://github.com/apache/iceberg/pull/6512#discussion_r1235519344
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -2615,6 +2616,100 @@ public void tableCreationWithoutNamespace() {
.hasMessageContaining("Namespace does not exist: non-existing");
}
+ @Test
+ public void testRegisterTable() {
+ C catalog = catalog();
+
+ if (requiresNamespaceCreate()) {
+ catalog.createNamespace(TABLE.namespace());
+ }
+
+ Map<String, String> properties =
+ ImmutableMap.of("user", "someone", "created-at",
"2023-01-15T00:00:01");
+ Table table =
+ catalog
+ .buildTable(TABLE, SCHEMA)
+ .withPartitionSpec(SPEC)
+ .withSortOrder(WRITE_ORDER)
+ .withProperties(properties)
+ .create();
+
+ table.newFastAppend().appendFile(FILE_A).commit();
+ table.newFastAppend().appendFile(FILE_B).commit();
+ table.newDelete().deleteFile(FILE_A).commit();
+ table.newFastAppend().appendFile(FILE_C).commit();
+
+ TableOperations ops = ((HasTableOperations) table).operations();
+ String metadataLocation = ops.current().metadataFileLocation();
+
+ catalog.dropTable(TABLE, false);
+
+ Table registeredTable = catalog.registerTable(TABLE, metadataLocation);
+ Assertions.assertThat(registeredTable).isNotNull();
+
+ TableOperations registeredTableOps = ((HasTableOperations)
table).operations();
+ Assertions.assertThat(metadataLocation)
+ .isEqualTo(registeredTableOps.current().metadataFileLocation());
+
+ Map<String, String> actualProperties = Maps.newHashMap(table.properties());
+ Map<String, String> expectedProperties =
Maps.newHashMap(table.properties());
+ // The nessie.commit.id for each table will be distinct, hence, it is
necessary to remove it
+ // before asserting the properties.
+ actualProperties.remove("nessie.commit.id");
+ expectedProperties.remove("nessie.commit.id");
+
+ Assertions.assertThat(table.location())
+ .as("Location must match")
+ .isEqualTo(registeredTable.location());
Review Comment:
I think this can be overridden by the catalog, I'd omit this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
