wypoon commented on code in PR #7744:
URL: https://github.com/apache/iceberg/pull/7744#discussion_r1239128963
##########
core/src/main/java/org/apache/iceberg/DataFiles.java:
##########
@@ -248,6 +268,16 @@ public Builder withPartitionPath(String newPartitionPath) {
return this;
}
+ public Builder withPartitionValues(List<String> partitionValues) {
+ Preconditions.checkArgument(
+ isPartitioned || partitionValues.isEmpty(),
+ "Cannot add partition data for an unpartitioned table");
+ if (!partitionValues.isEmpty()) {
Review Comment:
Actually, I see now that we should leave things as they are.
`SparkTableUtil.importUnpartitionedSparkTable` actually does call
`TableMigrationUtil.listPartition`, with an empty `Map` for `partition`, and so
that will call `DataFiles.Builder#withPartitionValues` with an empty `List` for
`partitionValues`. That should be allowed. *And it should indeed do nothing.*
(I tried the change I just proposed above, and some tests in
`TestMigrateTableProcedure` failed.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
