wypoon commented on code in PR #7744:
URL: https://github.com/apache/iceberg/pull/7744#discussion_r1239306101
##########
core/src/main/java/org/apache/iceberg/DataFiles.java:
##########
@@ -248,6 +268,16 @@ public Builder withPartitionPath(String newPartitionPath) {
return this;
}
+ public Builder withPartitionValues(List<String> partitionValues) {
+ Preconditions.checkArgument(
+ isPartitioned || partitionValues.isEmpty(),
+ "Cannot add partition data for an unpartitioned table");
+ if (!partitionValues.isEmpty()) {
Review Comment:
Or more succinctly,
```
Preconditions.checkArgument(
isPartitioned ^ partitionValues.isEmpty(),
"Table must be partitioned or partition values must be empty");
```
I didn't realize that `^` could be used as a logical xor as well as bitwise
xor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
