dimas-b commented on code in PR #7893:
URL: https://github.com/apache/iceberg/pull/7893#discussion_r1240139788
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -523,4 +528,49 @@ public void close() {
api.close();
}
}
+
+ public TableMetadata loadTableMetadataWithNessieSpecificProperties(
+ String metadataLocation, IcebergTable table, FileIO fileIO, String
identifier) {
+ // Update the TableMetadata with the Content of NessieTableState.
+ TableMetadata deserialized = TableMetadataParser.read(fileIO,
metadataLocation);
+ Map<String, String> newProperties =
Maps.newHashMap(deserialized.properties());
+ newProperties.put(NessieTableOperations.NESSIE_COMMIT_ID_PROPERTY,
getRef().getHash());
Review Comment:
`NessieIcebergClient.getRef()` actually looks like a rather internal method.
Perhaps it should be package-private. We could add a new public
`getReference()` method to return the current Nessie API `Reference`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
