ajantha-bhat commented on code in PR #7893:
URL: https://github.com/apache/iceberg/pull/7893#discussion_r1242191523
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -523,4 +528,49 @@ public void close() {
api.close();
}
}
+
+ public TableMetadata loadTableMetadataWithNessieSpecificProperties(
+ String metadataLocation, IcebergTable table, FileIO fileIO, String
identifier) {
+ // Update the TableMetadata with the Content of NessieTableState.
+ TableMetadata deserialized = TableMetadataParser.read(fileIO,
metadataLocation);
Review Comment:
@dimas-b, @nastra:
https://github.com/apache/iceberg/blob/9f12b85667362dbf0cc1bbb16972602a103938a8/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java#L208
Currently, `metadataLoader` just reads the tableMetadata for other catalogs
and it is under the retry as shown above.
If I read the file before and change `metadataLoader` to dummy for other
catalogs, it will be just an assignment operation for other catalogs and may
not need the retry.
I am not sure about the impact of removing the retry here. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
