szehon-ho commented on code in PR #7898:
URL: https://github.com/apache/iceberg/pull/7898#discussion_r1246952682
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -282,18 +304,35 @@ private static boolean
isLiteral(org.apache.spark.sql.connector.expressions.Expr
return expr instanceof Literal;
}
- private static Object convertLiteral(Literal<?> literal) {
+ @SuppressWarnings("unchecked")
+ private static <T> T convertLiteral(Literal<?> literal) {
Review Comment:
Same
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -245,6 +251,22 @@ public static Expression convert(Predicate predicate) {
return null;
}
+ private static <T> Pair<UnboundTerm<T>, T> predicateChildren(Predicate
predicate) {
Review Comment:
Question: should we remove <T>? Looks like all callers just use Object in
the end, and <T> just clutters a bit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
