ConeyLiu commented on code in PR #7898:
URL: https://github.com/apache/iceberg/pull/7898#discussion_r1247609599
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -289,11 +311,28 @@ private static Object convertLiteral(Literal<?> literal) {
return literal.value();
}
- private static Expression handleEqual(String attribute, Object value) {
- if (NaNUtil.isNaN(value)) {
- return isNaN(attribute);
+ private static UnboundPredicate<Object>
handleEqual(Pair<UnboundTerm<Object>, Object> children) {
+ if (children.second() == null) {
+ return isNull(children.first());
+ }
+
+ if (NaNUtil.isNaN(children.second())) {
+ return isNaN(children.first());
+ } else {
+ return equal(children.first(), children.second());
+ }
+ }
+
+ private static UnboundPredicate<Object> handleNotEqual(
+ Pair<UnboundTerm<Object>, Object> children) {
+ if (children.second() == null) {
+ return notNull(children.first());
+ }
+
+ if (NaNUtil.isNaN(children.second())) {
+ return notNaN(children.first());
} else {
- return equal(attribute, value);
+ return notEqual(children.first(), children.second());
Review Comment:
The string will be wrapped into `NamedReference`. There are two API as
follows:
```java
public static <T> UnboundPredicate<T> equal(String name, T value) {
return new UnboundPredicate<>(Expression.Operation.EQ, ref(name), value);
}
public static <T> UnboundPredicate<T> equal(UnboundTerm<T> expr, T value) {
return new UnboundPredicate<>(Expression.Operation.EQ, expr, value);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
