szehon-ho commented on code in PR #7920:
URL: https://github.com/apache/iceberg/pull/7920#discussion_r1247558247
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -73,6 +73,11 @@ public class PartitionsTable extends BaseMetadataTable {
"equality_delete_file_count",
Types.IntegerType.get(),
"Count of equality delete files"),
+ Types.NestedField.required(
+ 11,
+ "total_data_file_size_in_bytes",
+ Types.LongType.get(),
+ "Total size in bytes"),
Review Comment:
Ah sorry, in my previous comment I meant just change "total bytes' => 'total
size in bytes', but the rest was ok.
So can we revert back the original end of sentence?
'Total size in bytes of data files' (maybe 'in a partition' was redundant
there)
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -73,6 +73,11 @@ public class PartitionsTable extends BaseMetadataTable {
"equality_delete_file_count",
Types.IntegerType.get(),
"Count of equality delete files"),
+ Types.NestedField.required(
+ 11,
+ "total_data_file_size_in_bytes",
+ Types.LongType.get(),
+ "Total size in bytes"),
Review Comment:
Ah sorry, in my previous comment I meant just change "total bytes' => 'total
size in bytes', but the rest was ok.
So can we revert back the original end of sentence where you talked about
data files?
'Total size in bytes of data files' (maybe 'in a partition' was redundant
there)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
