szehon-ho commented on code in PR #7920:
URL: https://github.com/apache/iceberg/pull/7920#discussion_r1248181860
##########
docs/flink-queries.md:
##########
@@ -436,7 +436,7 @@ SELECT * FROM prod.db.table$partitions;
| {20211002, 10} | 1 | 1 | 0 |
Note:
-For unpartitioned tables, the partitions table will contain only the
record_count and file_count columns.
+For unpartitioned tables, the partitions table will contain only the
record_count, file_count, position_delete_record_count,
position_delete_file_count, equality_delete_record_count,
equality_delete_file_count, last_updated_ms, last_updated_snapshot_id and
total_data_file_size_in_bytes columns.
Review Comment:
Should we do this in another pr? I feel we need to edit the table above as
well.
Also, I think we can just say 'For unpartitioned tables, the partitions
table will not contain the partition and spec_id field', as the list of fields
we do support is becoming too big.
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -73,6 +73,8 @@ public class PartitionsTable extends BaseMetadataTable {
"equality_delete_file_count",
Types.IntegerType.get(),
"Count of equality delete files"),
+ Types.NestedField.required(
+ 11, "total_data_file_size_in_bytes", Types.LongType.get(),
"Total size in bytes"),
Review Comment:
This is still not changed back? "Total size in bytes of data files" Sorry
if its still pending
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
