ConeyLiu commented on code in PR #7898:
URL: https://github.com/apache/iceberg/pull/7898#discussion_r1248440325
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestSparkV2Filters.java:
##########
@@ -39,6 +39,7 @@
public class TestSparkV2Filters {
+ @SuppressWarnings("checkstyle:MethodLength")
Review Comment:
Split the internal test block to function `testV2Filter`.
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -289,11 +311,27 @@ private static Object convertLiteral(Literal<?> literal) {
return literal.value();
}
- private static Expression handleEqual(String attribute, Object value) {
+ private static UnboundPredicate<Object> handleEqual(UnboundTerm<Object>
term, Object value) {
+ if (value == null) {
+ return isNull(term);
+ }
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
