dramaticlly commented on code in PR #7920:
URL: https://github.com/apache/iceberg/pull/7920#discussion_r1251190339
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -1421,6 +1435,7 @@ public void testPartitionsTable() {
}
}
+ @SuppressWarnings("MethodLength")
Review Comment:
yeah I also run into this problem before. If your datafile total size
assertion is already covered in `testPartitionsTable` then I dont think it's
necessary to ido it again in `testPartitionsTableLastUpdatedSnapshot` since
what you tested are mostly the same scenario.
Also if you want to move file assertion into some helper method to reduce
line count, that's probably more preferred than suppress warning.
I can also help with follow up PR if needed, it's up to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
