nastra commented on code in PR #7992:
URL: https://github.com/apache/iceberg/pull/7992#discussion_r1254112125
##########
api/src/main/java/org/apache/iceberg/view/SQLViewRepresentation.java:
##########
@@ -37,17 +36,7 @@ default String type() {
/** The view query SQL dialect. */
String dialect();
- /** The default catalog when the view is created. */
- @Nullable
- String defaultCatalog();
Review Comment:
We discussed this internally yesterday and we can
1) remove the `default-catalog`
2) leave it at the representation level, because e.g. Trino's default
catalog can be different from Spark's default catalog. Also Trino stores the
catalog in its
[ViewDefinition](https://github.com/trinodb/trino/blob/e9ac9a1107cdbf4fec889bf26d8fa94199e706da/core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorViewDefinition.java#L39C1-L39C1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
