rdblue commented on code in PR #7992: URL: https://github.com/apache/iceberg/pull/7992#discussion_r1258604469
########## api/src/main/java/org/apache/iceberg/view/VersionBuilder.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.view; + +import org.apache.iceberg.catalog.Namespace; + +public interface VersionBuilder<T> { + /** + * Add a view representation for the given dialect and the SQL to the view. + * + * @param dialect The dialect of the view representation + * @param sql The SQL of the view representation + * @return this for method chaining + */ + default T withQuery(String dialect, String sql) { + return withQuery(dialect, sql, null); + } + + /** + * Add a view representation for the given dialect and the SQL to the view. + * + * @param dialect The dialect of the view representation + * @param sql The SQL of the view representation + * @param defaultNamespace The default namespace to use when the SQL does not contain a namespace + * @return this for method chaining + */ + T withQuery(String dialect, String sql, Namespace defaultNamespace); Review Comment: The default namespace should be a property of the view version, not a representation. `withDefaultNamespace` should be a separate method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
