hsiang-c commented on code in PR #8024:
URL: https://github.com/apache/iceberg/pull/8024#discussion_r1257476710
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java:
##########
@@ -798,11 +799,11 @@ public static List<ManifestFile> deleteManifests(Table
table) {
return table.currentSnapshot().deleteManifests(table.io());
}
- public static Set<DataFile> dataFiles(Table table) {
- return dataFiles(table, null);
+ public static Set<DataFile> uniqueDataFiles(Table table) {
+ return uniqueDataFiles(table, null);
}
- public static Set<DataFile> dataFiles(Table table, String branch) {
+ public static Set<DataFile> uniqueDataFiles(Table table, String branch) {
Review Comment:
@szehon-ho I renamed it to distinguish it from `List` based implementation.
Not sure if `Set` based implementation is a must?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
