szehon-ho commented on code in PR #8024:
URL: https://github.com/apache/iceberg/pull/8024#discussion_r1260080722
##########
spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##########
@@ -145,11 +145,11 @@ public void testDeleteFileThenMetadataDelete() throws
Exception {
// Metadata Delete
Table table = Spark3Util.loadIcebergTable(spark, tableName);
- Set<DataFile> dataFilesBefore = TestHelpers.dataFiles(table);
+ Set<DataFile> dataFilesBefore = TestHelpers.uniqueDataFiles(table);
Review Comment:
Does the test pass with using dataFiles? (if we change to List) Looks like
we are just comparing size, which should hopefully work?
Just wanted to avoid another test method if possible.
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -136,7 +136,7 @@ public void testEmptyTable() {
@Test
public void testUnpartitioned() throws Exception {
Table table = createTableUnpartitioned(2, SCALE);
- List<DataFile> dataFiles = dataFiles(table);
+ List<DataFile> dataFiles = TestHelpers.dataFiles(table, true);
Review Comment:
Seeing all these test pass in true, I'm thinking it may be ok to just always
include column stats , then, to avoid passing true all the time.
The not includeColumnStats is to increase performance, but I think it doesnt
matter that much for tests. I dont think any test logic would break if we have
column stats.
(Sorry I think it was probably my original comment to pass in false in the
Partitions Table tests, as at the time we had an easier choice to include it or
not)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
