[ 
https://issues.apache.org/jira/browse/IGNITE-12938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102486#comment-17102486
 ] 

Stanilovsky Evgeny commented on IGNITE-12938:
---------------------------------------------

[~ascherbakov] thanks for review ! 
I partially fixed your pr comments and point 2.
What about point 1, i double checked all this checks i.e. : "--cache", 
"idle_verify" and "--cache", "validate_indexes"  i found that all correct for 
now.
1. Check 
{noformat}VerifyBackupPartitionsTaskV2#checkConflicts{noformat}
 and further 
{noformat}if (record.updateCounter() != updateCntr){noformat} seem all correct 
here.
2. {noformat}integrityCheckIndexesPartitions{noformat} checks only crc problems 
- no need updCounter here.
3. All other checks have additional info and further check through this : 
{noformat}ValidateIndexesPartitionResult#updateCntr{noformat}
 did i miss something ?
 


> control.sh utility commands: IdleVerify and ValidateIndexes use eventual 
> payload check.
> ---------------------------------------------------------------------------------------
>
>                 Key: IGNITE-12938
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12938
>             Project: Ignite
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 2.8
>            Reporter: Stanilovsky Evgeny
>            Assignee: Stanilovsky Evgeny
>            Priority: Major
>             Fix For: 2.9
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> "--cache idle_verify" and "--cache validate_indexes" commands of *control.sh* 
>  utility use eventual payload check during  execution. This can lead to 
> execution concurrently with active payload and no errors like : "Checkpoint 
> with dirty pages started! Cluster not idle"  will be triggered. Additionally 
> current functional miss check on caches without persistence.  Remove old 
> functionality from PageMemory and move it into update counters usage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to