[ 
https://issues.apache.org/jira/browse/IGNITE-12938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106111#comment-17106111
 ] 

Stanilovsky Evgeny commented on IGNITE-12938:
---------------------------------------------

[~ascherbakov] now it`s clear to me that all checks executed in scope of : 
ValidateIndexesClosure#call0 holds only local checks and in reduce side only 
issues are taken into account : CacheValidateIndexes#execute, thus - no full 
updates info need here, but your comment looks like valid for concurrent cahe 
and index sizes checks :

{noformat}
cacheSizeFutures.add(new T3<>(cacheGrpCtx, locPart, 
calcCacheSizeAsync(cacheGrpCtx, locPart)));
..
idxSizeFutures.add(new T3<>(cacheCtx, idx, calcIndexSizeAsync(cacheCtx, idx, 
idleChecker))); 
{noformat}

i cover this cases by additional check all update counters before and after 
mentioned operations:

{noformat}
List<Integer> diff = compareUpdateCounters(ignite, partsWithCntrsPerGrp, 
partsWithCntrsPerGrpAfterChecks);
{noformat}

for VerifyBackupPartitionsTaskV2 it`s looks like you comment is valid i add 
reservedCounters check.

if now you ok i will proceed with TC.

thanks !

> control.sh utility commands: IdleVerify and ValidateIndexes use eventual 
> payload check.
> ---------------------------------------------------------------------------------------
>
>                 Key: IGNITE-12938
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12938
>             Project: Ignite
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 2.8
>            Reporter: Stanilovsky Evgeny
>            Assignee: Stanilovsky Evgeny
>            Priority: Major
>             Fix For: 2.9
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> "--cache idle_verify" and "--cache validate_indexes" commands of *control.sh* 
>  utility use eventual payload check during  execution. This can lead to 
> execution concurrently with active payload and no errors like : "Checkpoint 
> with dirty pages started! Cluster not idle"  will be triggered. Additionally 
> current functional miss check on caches without persistence.  Remove old 
> functionality from PageMemory and move it into update counters usage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to