[
https://issues.apache.org/jira/browse/IGNITE-13015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144856#comment-17144856
]
Ignite TC Bot commented on IGNITE-13015:
----------------------------------------
{panel:title=Branch: [pull/7872/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/7872/head] Base: [master] : New Tests
(8)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Service Grid{color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple
[val1=DiscoveryEvent [evtNode=d351f2fe-fba4-4ee8-ade1-9227a5e5bb68, topVer=0,
nodeId8=df353f4f, msg=, type=NODE_JOINED, tstamp=1593003522082],
val2=AffinityTopologyVersion [topVer=4098316748227185059, minorTopVer=0]]] -
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest
[id=628b866e271-3fd5b0ac-1101-4307-b308-2993a416b303, reqs=SingletonList
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent
[evtNode=4539469b-23ce-47da-b414-d88ba5f80e44, topVer=0, nodeId8=4539469b,
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593003522082]],
val2=AffinityTopologyVersion [topVer=-3612007881158358712, minorTopVer=0]]] -
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest
[id=628b866e271-3fd5b0ac-1101-4307-b308-2993a416b303, reqs=SingletonList
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent
[evtNode=4539469b-23ce-47da-b414-d88ba5f80e44, topVer=0, nodeId8=4539469b,
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593003522082]],
val2=AffinityTopologyVersion [topVer=-3612007881158358712, minorTopVer=0]]] -
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple
[val1=DiscoveryEvent [evtNode=d351f2fe-fba4-4ee8-ade1-9227a5e5bb68, topVer=0,
nodeId8=df353f4f, msg=, type=NODE_JOINED, tstamp=1593003522082],
val2=AffinityTopologyVersion [topVer=4098316748227185059, minorTopVer=0]]] -
PASSED{color}
{color:#00008b}Service Grid (legacy mode){color} [tests 4]
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple
[val1=DiscoveryEvent [evtNode=8ac76949-2853-493e-b260-6b18fc665c69, topVer=0,
nodeId8=f810e816, msg=, type=NODE_JOINED, tstamp=1593003634595],
val2=AffinityTopologyVersion [topVer=-1632607971326416117, minorTopVer=0]]] -
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple
[val1=DiscoveryEvent [evtNode=8ac76949-2853-493e-b260-6b18fc665c69, topVer=0,
nodeId8=f810e816, msg=, type=NODE_JOINED, tstamp=1593003634595],
val2=AffinityTopologyVersion [topVer=-1632607971326416117, minorTopVer=0]]] -
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest
[id=0469476e271-3da79bad-992d-4b81-bf15-d79caf2ee2e3, reqs=SingletonList
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent
[evtNode=49995b33-59e0-4162-b7c4-40c4c38419ee, topVer=0, nodeId8=49995b33,
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593003634595]],
val2=AffinityTopologyVersion [topVer=5211255272149192301, minorTopVer=0]]] -
PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple
[val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest
[id=0469476e271-3da79bad-992d-4b81-bf15-d79caf2ee2e3, reqs=SingletonList
[ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent
[evtNode=49995b33-59e0-4162-b7c4-40c4c38419ee, topVer=0, nodeId8=49995b33,
msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1593003634595]],
val2=AffinityTopologyVersion [topVer=5211255272149192301, minorTopVer=0]]] -
PASSED{color}
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5414195&buildTypeId=IgniteTests24Java8_RunAll]
> Use nano time in node failure detection.
> ----------------------------------------
>
> Key: IGNITE-13015
> URL: https://issues.apache.org/jira/browse/IGNITE-13015
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 2.8.1
> Reporter: Vladimir Steshin
> Assignee: Vladimir Steshin
> Priority: Minor
> Labels: iep-45
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Make sure node failure detection do not use:
> {code:java}
> System.currentTimeMillis()
> and
> IgniteUtils.currentTimeMillis()
> {code}
> We should use nano time instead. Disadventages of current impl.:
> 1) System time has no quarantine of strict forward movement. System time
> can be adjusted, synchronized by NTP as example. This can lead to incorrect
> and negative delays.
> 2) IgniteUtils.currentTimeMillis() is granulated by 10ms
> *To fix*:
> {code:java}ServerImpl.lastRingMsgReceivedTime{code} should be nano.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
