[ 
https://issues.apache.org/jira/browse/IGNITE-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152676#comment-17152676
 ] 

Aleksey Plekhanov commented on IGNITE-13219:
--------------------------------------------

[~liyuj], as far as I understand - the only goal you want to achieve by this 
patch is to set some system property. This looks like some user-specific case 
and I'm not sure that we should change Ignite for this scenario. It can be 
easily implemented in user code. Another reason why we shouldn't do it in 
Ignite - in general, there can be several Ignite nodes inside one JVM and the 
system property will be overwritten in this case with unpredictable to logger 
results.

> Slf4jLogger does not implement the LoggerNodeIdAware interface.
> ---------------------------------------------------------------
>
>                 Key: IGNITE-13219
>                 URL: https://issues.apache.org/jira/browse/IGNITE-13219
>             Project: Ignite
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 2.8.1
>            Reporter: YuJue Li
>            Assignee: YuJue Li
>            Priority: Minor
>             Fix For: 2.9
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the scenario of ignite + slf4j + log4j2, the generated log file is named 
> ignite-${sys:nodeId}.log, The reason for this problem is that Slf4jLogger 
> does not implement the
> LoggerNodeIdAware interface.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to