[ 
https://issues.apache.org/jira/browse/IGNITE-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155452#comment-17155452
 ] 

Aleksey Plekhanov commented on IGNITE-13219:
--------------------------------------------

[~ilyak], I think it's very fragile. Log4j uses the current value for system 
property, but not initialization-time value.

Here is reproducer:  
{code:java}
Ignite ignite1 = Ignition.start(new 
IgniteConfiguration().setIgniteInstanceName("ignite1")
        .setGridLogger(new Log4J2Logger("config/ignite-log4j2.xml")));

Ignite ignite2 = Ignition.start(new 
IgniteConfiguration().setIgniteInstanceName("ignite2")
        .setGridLogger(new Log4J2Logger("config/ignite-log4j2.xml")));

System.setProperty("nodeId", "test");
{code}
After ignite2 starts both nodes start writing to the same log, after 
setProperty they both start writing to ignite-test.log. 

> Slf4jLogger does not implement the LoggerNodeIdAware interface.
> ---------------------------------------------------------------
>
>                 Key: IGNITE-13219
>                 URL: https://issues.apache.org/jira/browse/IGNITE-13219
>             Project: Ignite
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 2.8.1
>            Reporter: YuJue Li
>            Assignee: YuJue Li
>            Priority: Minor
>             Fix For: 2.9
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In the scenario of ignite + slf4j + log4j2, the generated log file is named 
> ignite-${sys:nodeId}.log, The reason for this problem is that Slf4jLogger 
> does not implement the
> LoggerNodeIdAware interface.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to