[
https://issues.apache.org/jira/browse/IGNITE-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175008#comment-17175008
]
Andrey N. Gura commented on IGNITE-13151:
-----------------------------------------
[~akalashnikov] LGTM. But a couple of comments:
- newly created classes should be documented better and more carefully;
- it's surprising to me that {{DbCheckpointContextImpl}} has {{Db}} prefix
while other new classes don't have such prefix.
> Checkpointer code refactoring: extracting classes from
> GridCacheDatabaseSharedManager
> -------------------------------------------------------------------------------------
>
> Key: IGNITE-13151
> URL: https://issues.apache.org/jira/browse/IGNITE-13151
> Project: Ignite
> Issue Type: Sub-task
> Components: persistence
> Reporter: Sergey Chugunov
> Assignee: Anton Kalashnikov
> Priority: Major
> Labels: IEP-47
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Checkpointer is at the center of Ignite persistence subsystem and more people
> from the community understand it the better means it is more stable and more
> efficient.
> However for now checkpointer code sits inside of
> GridCacheDatabaseSharedManager class and is entangled with this higher-level
> and more general component.
> To take a step forward to more modular checkpointer we need to do two things:
> # Move checkpointer code outside database manager to a separate class.
> (That's what this ticket is about.)
> # Create a well-defined API of checkpointer that will allow us to create new
> implementations of checkpointer in the future. An example of this is new
> checkpointer implementation needed for defragmentation feature purposes.
> (Should be done in a separate ticket)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
