[ 
https://issues.apache.org/jira/browse/IGNITE-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177015#comment-17177015
 ] 

Anton Kalashnikov commented on IGNITE-13151:
--------------------------------------------

[~agura] Thanks for your comment, but there are no new classes, in fact, all of 
these classes were extracted mostly from GridCacheDatabaseSharedManager with 
minimum changes. So I agree that javadocs are not perfect and I improved it a 
little but the further improvement I suggest to do in my next task because 
these classes will be changed. It is the same about naming - I left old names 
for easier the review but in the further, it is a high probability that I will 
find a more suitable name for them.

[~sergey-chugunov] can you recheck these changes(there are not a lot of changes 
since the last time) and merge it to master.

> Checkpointer code refactoring: extracting classes from 
> GridCacheDatabaseSharedManager
> -------------------------------------------------------------------------------------
>
>                 Key: IGNITE-13151
>                 URL: https://issues.apache.org/jira/browse/IGNITE-13151
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: persistence
>            Reporter: Sergey Chugunov
>            Assignee: Anton Kalashnikov
>            Priority: Major
>              Labels: IEP-47
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Checkpointer is at the center of Ignite persistence subsystem and more people 
> from the community understand it the better means it is more stable and more 
> efficient.
> However for now checkpointer code sits inside of 
> GridCacheDatabaseSharedManager class and is entangled with this higher-level 
> and more general component.
> To take a step forward to more modular checkpointer we need to do two things:
>  # Move checkpointer code outside database manager to a separate class. 
> (That's what this ticket is about.)
>  # Create a well-defined API of checkpointer that will allow us to create new 
> implementations of checkpointer in the future. An example of this is new 
> checkpointer implementation needed for defragmentation feature purposes. 
> (Should be done in a separate ticket)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to