[
https://issues.apache.org/jira/browse/IGNITE-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307608#comment-15307608
]
Denis Magda commented on IGNITE-3207:
-------------------------------------
[~F7753], I've reviewed your changes and left some comments in the pull
request. Please consider them as well as Dmitriy's suggestion above (rename all
"localInstanceName" occurrences into "instanceName").
After you do address all the inputs please do the following:
- update your pull-request;
- check all the changes against TeamCity. Refer to this page [1] for more
details on how to start the test suites;
- move this issue into "PATCH_AVAILABLE" state if the tests look good;
- ask for one more review round.
[1]
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request
> Rename IgniteConfiguration.gridName
> -----------------------------------
>
> Key: IGNITE-3207
> URL: https://issues.apache.org/jira/browse/IGNITE-3207
> Project: Ignite
> Issue Type: Improvement
> Components: general
> Affects Versions: 1.1.4
> Reporter: Pavel Tupitsyn
> Assignee: Biao Ma
> Fix For: 1.7
>
>
> We have got a TON of questions on gridName property. Everyone thinks that
> clusters are formed based on the gridName, that is, nodes with the same grid
> name will join one cluster, and nodes with a different name will be in a
> separate cluster.
> Let's do the following:
> * Deprecate IgniteConfiguration.gridName
> * Add IgniteConfiguration.localInstanceName
> * Rename related parameters in Ignition class (and other places, if present)
> * Update Javadoc: clearly state that this name only works locally and has no
> effect on topology.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
