[
https://issues.apache.org/jira/browse/IGNITE-18875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707104#comment-17707104
]
Gael Yimen Yimga commented on IGNITE-18875:
-------------------------------------------
[~zstan] and [~amashenkov]
I have created this [pull request|https://github.com/apache/ignite-3/pull/1873]
to address this ticket. But I have made the following remark.
||Branch Name||Total Number of Tests||Total Number of Failures Tests||Total
Number of Ignored Tests||
|Main|1290|378|21|
|IGNITE-18875|1253|562|21|
1) First Notice is that the main branch has some test failures. i ran the
following command .{_}*/gradlew clean test*{_} in order to run the tests. I was
expecting the main branch to have zero failures. if that is the case, what am I
doing wrong ?
2) Second notice, after my change in my branch, the number of total test
increased, what is causing that ? and given that I have neither created new
tests, nor deleted any tests, why is that the total number of Tests decreased ?
3) Can you guys please help on reviewing my pull request and advice if I'm in
the right direction ?
> Sql. Drop AbstractPlannerTest.TestTable.
> ----------------------------------------
>
> Key: IGNITE-18875
> URL: https://issues.apache.org/jira/browse/IGNITE-18875
> Project: Ignite
> Issue Type: Improvement
> Components: sql
> Reporter: Andrey Mashenkov
> Assignee: Gael Yimen Yimga
> Priority: Major
> Labels: ignite-3, newbie, tech-debt-test
> Fix For: 3.0.0-beta2
>
>
> Use test framework for schema configuration in tests.
> Replace
> {code:java}
> org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.TestTable
> {code}
> with
> {code:java}
> org.apache.ignite.internal.sql.engine.framework.TestTable
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
