[
https://issues.apache.org/jira/browse/IGNITE-18875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709122#comment-17709122
]
Gael Yimen Yimga commented on IGNITE-18875:
-------------------------------------------
[~zstan] I think the approach I took to address this ticket is the right one. I
would like to start from the beginning and explain my way of seeing the
solution. I noticed that there are many classes that uses TestTable class. Some
class have their own version of TestTable that they use. After my analysis, i
found out that if I'm going blindly and try to fix each problem that i
encounter i will never finish. Instead, what I'm planning to do is the
following.
I would like to use the design pattern Decorator, where I will have an
abstract/interface class TestTable. We have different type of TestTable
depending on where they are used. So I will have these different TestTable that
will inherit from the abstract/interface TestTable. Then, I will have a
decorator that will be implemented to differentiate every specific type of
TestTable to use in each different test that use them.
What Do you think about this approach ?
Do you think I'm overkilling this ticket ?
What will be your suggestion in order to solve this ticket?
Thanks in advance.
> Sql. Drop AbstractPlannerTest.TestTable.
> ----------------------------------------
>
> Key: IGNITE-18875
> URL: https://issues.apache.org/jira/browse/IGNITE-18875
> Project: Ignite
> Issue Type: Improvement
> Components: sql
> Reporter: Andrey Mashenkov
> Assignee: Gael Yimen Yimga
> Priority: Major
> Labels: ignite-3, newbie, tech-debt-test
> Fix For: 3.0.0-beta2
>
> Attachments: Screen Shot 2023-04-03 at 1.04.39 AM.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Use test framework for schema configuration in tests.
> Replace
> {code:java}
> org.apache.ignite.internal.sql.engine.planner.AbstractPlannerTest.TestTable
> {code}
> with
> {code:java}
> org.apache.ignite.internal.sql.engine.framework.TestTable
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
