[
https://issues.apache.org/jira/browse/IGNITE-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415285#comment-15415285
]
Vladimir Ozerov commented on IGNITE-3650:
-----------------------------------------
Taras, my comments:
1) Styling: missing header in {{LocalFileSystemIgfsFile}}
2) Styling: missing docs for fields in {{LocalFileSystemIgfsFile}}
3) Styling: unused imports in {{LocalFileSystemIgfsFile}}
4) I would add an assert to ctor of {{LocalFileSystemIgfsFile}} ensuring that
block size and size is always 0 for directory.
5) Looks like there is no need to bother with {{Path}} class and associated
exceptions, as both mod time, length and isFile/isDir is accessible from
{{java.io.File}} class with less boilerplate code.
6) It doesn't make sense to make "size" system call if we know in advance that
this is not a file. Just pass null to save a system call for directories.
7) I am not sure it makes sense to pass empty collection. Instead, we'd better
to pass null. The reason for this is that we have multiple serialization
mechanisms. Singleton {{Collections.<String, String>emptyMap()}} can easily be
converted to materialized collection on the other side of the wire. To avoid
that we'd better to pass {{null}} - just for safety.
8) We cannot pass arbitrary block size. If we do not know it, then let's agree
on some contract. E.g. we may say that zero will denote unknown block size for
a file. This could lead to some assertion failures, what mean that these
assertions should be adjusted accordingly.
> IGFS: Local secondary: Implement "info()" operation.
> ----------------------------------------------------
>
> Key: IGNITE-3650
> URL: https://issues.apache.org/jira/browse/IGNITE-3650
> Project: Ignite
> Issue Type: Sub-task
> Components: IGFS
> Affects Versions: 1.6
> Reporter: Vladimir Ozerov
> Assignee: Taras Ledkov
> Fix For: 1.8
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
