[
https://issues.apache.org/jira/browse/IGNITE-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493216#comment-15493216
]
ASF GitHub Bot commented on IGNITE-3621:
----------------------------------------
GitHub user amartianov opened a pull request:
https://github.com/apache/ignite/pull/1066
IGNITE-3621 Make GridCacheTtlManager singleton
Use single Ttl Cleanup Worker thread for all caches
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-3621
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/1066.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1066
----
commit dc4fb203ea0a98f77b3aeddaccc02ef02f7cc554
Author: Andrey Martianov <[email protected]>
Date: 2016-09-15T07:35:58Z
IGNITE-3621 use single Ttl Cleanup Worker thread for all caches
----
> Make GridCacheTtlManager singleton
> ----------------------------------
>
> Key: IGNITE-3621
> URL: https://issues.apache.org/jira/browse/IGNITE-3621
> Project: Ignite
> Issue Type: Bug
> Components: cache
> Affects Versions: 1.6
> Reporter: Eduard Shangareev
> Assignee: Andrey Martianov
> Labels: performance
>
> Now every cache has own TTL manager, which creates CleanupWorker = new extra
> thread. This can cause to extra hundreds of threads (redundant context
> switches = performance penalty).
> Also, under IGNITE-3513 every put can enter critical section to notify
> worker. Obviously, it is not good from performance point of view.
> So, my proposal is next:
> 1. Expiration should be done on every cache action (on exit thread which
> updates cache should invoke {{expire}}).
> 2. TtlManager will exist only in one instance.
> 3. CleanupWorker will be the only backup if there is no cache activity. It
> will wake up with some period to check for work (500 ms, for example).
> Moreover, now we keep on-heap pending entries even if a cache is kept
> off-head. At least, this issue needs discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
