[
https://issues.apache.org/jira/browse/IGNITE-26631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18126255#comment-18126255
]
Ignite TC Bot commented on IGNITE-26631:
----------------------------------------
{panel:title=Branch: [pull/13652/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/13652/head] Base: [master] : No new tests
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=9406283&buildTypeId=IgniteTests24Java8_RunAll]
{color:#ffffff}tcbot-analysis-comment chainBuildId=9406283
rerunBuildIds=none{color}
> Combine or refactor GridCacheGroupIdMessage and GridCacheIdMessage
> ------------------------------------------------------------------
>
> Key: IGNITE-26631
> URL: https://issues.apache.org/jira/browse/IGNITE-26631
> Project: Ignite
> Issue Type: Improvement
> Reporter: Vladimir Steshin
> Assignee: Reza Taroosheh
> Priority: Minor
> Labels: IEP-132, ise, wire-format
> Fix For: 2.19
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> These messages are similar and are only for providing a cache or a group id
> to find proper cache message handler. Currently, we use `{_}instance of{_}`.
> Instead, we should revise these messages and probably combine them.
>
> Also, check in {_}GridCacheIoManager{_}:
> {code:java}
> private Object descriptorForMessage(GridCacheMessage msg) {
> if (msg instanceof GridCacheIdMessage)
> return
> cctx.cache().cacheDescriptor(((GridCacheIdMessage)msg).cacheId());
> else if (msg instanceof GridCacheGroupIdMessage)
> return
> cctx.cache().cacheGroupDescriptors().get(((GridCacheGroupIdMessage)msg).groupId());
> return null;
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
