[
https://issues.apache.org/jira/browse/IGNITE-26631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132432#comment-18132432
]
Vladimir Steshin commented on IGNITE-26631:
-------------------------------------------
Hi, [~rezataroosheh]
Sorry for the late answer. Thank you for your participation.
This change is not quite what we expected. Yes, a minor refactoring is
possible. But the question is why we have two messages. Can we combine them?
I’m afraid it is not that simple after the Rolling Upgrade (RU) feature
([IEP-132|https://cwiki.apache.org/confluence/spaces/IGNITE/pages/327978322/IEP-132+Rolling+Upgrade]):
we have to support the wire format for a node of version N-1. Changing these
messages would definitely change the wire format. We use Ignite features to
track such changes ({{{}CoreFeatureRegistry{}}}).
We also need compatibility tests.
> Combine or refactor GridCacheGroupIdMessage and GridCacheIdMessage
> ------------------------------------------------------------------
>
> Key: IGNITE-26631
> URL: https://issues.apache.org/jira/browse/IGNITE-26631
> Project: Ignite
> Issue Type: Improvement
> Reporter: Vladimir Steshin
> Assignee: Reza Taroosheh
> Priority: Minor
> Labels: IEP-132, ise, wire-format
> Fix For: 2.19
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> These messages are similar and are only for providing a cache or a group id
> to find proper cache message handler. Currently, we use `{_}instance of{_}`.
> Instead, we should revise these messages and probably combine them.
>
> Also, check in {_}GridCacheIoManager{_}:
> {code:java}
> private Object descriptorForMessage(GridCacheMessage msg) {
> if (msg instanceof GridCacheIdMessage)
> return
> cctx.cache().cacheDescriptor(((GridCacheIdMessage)msg).cacheId());
> else if (msg instanceof GridCacheGroupIdMessage)
> return
> cctx.cache().cacheGroupDescriptors().get(((GridCacheGroupIdMessage)msg).groupId());
> return null;
> } {code}
>
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
