[
https://issues.apache.org/jira/browse/IGNITE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615580#comment-15615580
]
Semen Boikov commented on IGNITE-500:
-------------------------------------
Hi Anton,
I did quick review, issues found so far:
- as I understand new streaming by 'current topology + affinity' is needed only
when IsolatedUpdater is used (i.e. allowOverwrite=false)? I think you need fix
DataStreamerImpl.nodes to use 'cctx.topology().nodes' only for IsolatedUpdater,
also you do not need to add new field in DataStreamerRequest, allowOverwriet is
true is updater 'instance of IsolatedUpdater'
- in DataStreamerImpl constructor you create cache if it does not exists _only_
for clients. Why this is not needed for server nodes?
- in Ignite code 'catch (Throwable ex)' is not usually used, why you need catch
Throwable? If this is really needed then you must re-throw Errors.
- please add test with server nodes restart in
CacheLoadingConcurrentGridStartSelfTest
- I did not understand changes in GridCompoundFuture, please explain
- I pushed few minor changes in branch, please take a look
Thanks!
> CacheLoadingConcurrentGridStartSelfTest fails
> ---------------------------------------------
>
> Key: IGNITE-500
> URL: https://issues.apache.org/jira/browse/IGNITE-500
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Yakov Zhdanov
> Assignee: Anton Vinogradov
> Priority: Critical
> Labels: Muted_test, important, user-request
> Fix For: 1.8
>
> Attachments: ignite-500.log
>
>
> http://apacheignite.readme.io/v1.0/discuss/550865a8e35e9c3b0083af3e
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
