[
https://issues.apache.org/jira/browse/IGNITE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657240#comment-15657240
]
Vladimir Ozerov commented on IGNITE-4198:
-----------------------------------------
Hi Roman,
I have several comments on the fix:
1) If transformer class instantiation failed, you only print exception to the
log. This way application will continue working without transformer. I would
prefer if we fail the whole start process, but I am not sure how Kafka will
handle it. Please advise.
2) I would rename new property to {{SINGLE_TUPLE_EXTRACTOR_CLASS}} or so. In
this case user will have clear understanding on what interface to implement.
Moreover, in future we may end up in situation when user would like to extract
several values from particular Kafka message so that we add more generic
{{TUPLE_EXTRACTOR_CLASS}} property.
The rest looks good to me.
Vladimir.
> Ignite Kafka sink connector should have an option to transform Kafka values
> ---------------------------------------------------------------------------
>
> Key: IGNITE-4198
> URL: https://issues.apache.org/jira/browse/IGNITE-4198
> Project: Ignite
> Issue Type: Improvement
> Components: streaming
> Affects Versions: 1.7
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Labels: community, streaming
> Fix For: 1.8
>
>
> Currently the connector takes a Kafka key and uses it as an Ignite key.
> However, Kafka keys can be null, and users may want to specify an Ignite key
> from the value object.
> Instead of creating a new transformer interface, I think we can use
> {{StreamMultipleTupleExtractor}} whenever its implementation is specified by
> the user in connector config file.
> http://apache-ignite-users.70518.x6.nabble.com/Kafka-Failed-to-stream-a-record-with-null-key-td8731.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
