[
https://issues.apache.org/jira/browse/IGNITE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667272#comment-15667272
]
Vladimir Ozerov commented on IGNITE-4198:
-----------------------------------------
Hi Roman,
My last comment is that we'd better to align property name with variable name:
instead of {{entryTransformerCls}} I would name it {{singleTupleExtractorCls}}.
The rest looks good to me. As per extractor interface I do not know the context
well. Personally I'd prefer to have separate interfaces. Because otherwise it
is not clear which method to invoke - {{single}} or {{multiple}}? So to support
two methods in the same interface we probably will have to add even more
methods, like {{isSingle}}. But again, I do not know Kafka good enough to judge
on the matter, this is just my thoughts. May be I am missing something.
Vladimir.
> Ignite Kafka sink connector should have an option to transform Kafka values
> ---------------------------------------------------------------------------
>
> Key: IGNITE-4198
> URL: https://issues.apache.org/jira/browse/IGNITE-4198
> Project: Ignite
> Issue Type: Improvement
> Components: streaming
> Affects Versions: 1.7
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Labels: community, streaming
> Fix For: 1.8
>
>
> Currently the connector takes a Kafka key and uses it as an Ignite key.
> However, Kafka keys can be null, and users may want to specify an Ignite key
> from the value object.
> Instead of creating a new transformer interface, I think we can use
> {{StreamMultipleTupleExtractor}} whenever its implementation is specified by
> the user in connector config file.
> http://apache-ignite-users.70518.x6.nabble.com/Kafka-Failed-to-stream-a-record-with-null-key-td8731.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
