[
https://issues.apache.org/jira/browse/IGNITE-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998193#comment-15998193
]
Vladimir Ozerov commented on IGNITE-5052:
-----------------------------------------
[~al.psc], my comments:
1) {{GridQueryProcessor}} - {{IgniteQueryErrorCode}} should not be used in this
class;
2) {{GridQueryProcessor}} - looks like new methods should not reside here at
all. This processing should be performed in H2, isn't it?
3) {{GridQueryProcessor.dynamicTableCreate}} - if template already contains
another query entity, we should throw an exception, instead of clearing it
silently;
4) {{GridQueryProcessor.dynamicTableCreate}} - we should hack
{{GridCacheProcessor}} to allow for returning {{true}}/{{false}} on whether
cache was created by this call or not. This will allow us to reliably check
whether cache was created by our call or not.
5) {{GridQueryProcessor.dynamicTableCreate}} - if cache already exists, there
is no need to compare anything in cache config. Just no-op or exception
depending on {{ifNotExists}} flag.
6) {{IgniteQueryErrorCode}} - I would remove all new error codes and use
{{PARSING}} for all those cases.
7) {{DdlStatementsProcessor.toQueryEntity}} - {{_KEY}} and {{_VAL}} handling
appears to be a {{PARSING}} error to me as well, not {{UNEXPECTED_OPERATION}}.
8) {{GridSqlCreateTable.getSQL}} - looks like we do not need this.
9) {{GridSqlQueryParser.parseCreateTable}} - do we take in count {{PRIMARY
KEY}} constraint defined separately from column?
> Implement CREATE/DROP table parsing and execution
> -------------------------------------------------
>
> Key: IGNITE-5052
> URL: https://issues.apache.org/jira/browse/IGNITE-5052
> Project: Ignite
> Issue Type: Task
> Components: SQL
> Reporter: Vladimir Ozerov
> Assignee: Alexander Paschenko
> Labels: important
> Fix For: 2.1
>
>
> Convert SQL string to relevant Igntie command. This could be:
> - {{createCache}}
> - {{getOrCreateCache}} (for {{IF NOT EXISTS}} case)
> - {{destroyCache}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
