Vladimir Ozerov commented on IGNITE-5163:

[~tledkov-gridgain], my comments:

1) {{BinaryUtils}}: unused method {{doReadSqlDateArray}}; Is it a bug or just 
dead code?
2) {{SqlListenerRequestHandlerImpl}}: call to {{getOrStartPublicCache}}? what 
3) {{SqlListenerProcessor}}: check for {{BinaryMarshaller}} is removed, but did 
you add it to ODBC handshake?
4) {{IgniteJdbcThinDriver.PARAM_TX_ALLOWED}}: we will support transactions in 
SQL quite soon, so I think it is better to remove this property and print a 
warning instead
5) {{JdbcTcpIo.closed}}: no JavaDocs
6) {{JdbcTcpIo.start}}: silent close without prtinting anything to log? How 
users are going to understand what is wrong when they receive a connection 
which is closed without a reason?
7) {{JdbcTcpIo.handshake}}: inconclusive error message; what should user do 
when receiving this kind of error?
8) {{JdbcTcpIo.read}}: please follow standard error message format
9) {{JdbcConnection}}: duplciate code in {{createStatement}} and 
{{prepareStatement}}. This should be refactored into common validation routine
10) {{JdbcConnection.setAutoCommit}}: show a warning instead of exception
11) {{JdbcConnection}}: {{getAutoCommit}} and {{getHoldability}} - inconsistent 
with other tx-related methods (e.g. {{getTransactionIsolation}})
12) {{JdbcConnectiongetWarnings/clearWarnings}}: do we have a ticket for this? 
it could be important for warnings about unsupported transactions
13) Does ODBC works fine at the moment?

> JDBC Driver: implement handshake for thin jdbc driver based on common 
> odbc/jdbc protocol
> ----------------------------------------------------------------------------------------
>                 Key: IGNITE-5163
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5163
>             Project: Ignite
>          Issue Type: Task
>          Components: odbc, sql
>    Affects Versions: 1.9
>            Reporter: Taras Ledkov
>            Assignee: Taras Ledkov
>             Fix For: 2.1
> The GridClient must be removed from thin jdbc driver.
> It is the first step to unify JDBC & ODBC protocols.

This message was sent by Atlassian JIRA

Reply via email to