[ 
https://issues.apache.org/jira/browse/IGNITE-5468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073997#comment-16073997
 ] 

Vitaliy Biryukov  commented on IGNITE-5468:
-------------------------------------------

[~amashenkov], could you please take a look now.

Maybe I should have made method signatures like this:
 private Iterable<List<?>> runQueryTwoStep(
        final String schemaName,
        final GridCacheTwoStepQuery qry,
        final boolean keepCacheObj,
        final boolean enforceJoinOrder,
        final int timeoutMillis,
        final int maxFetchSize,
        final int prefetchSize,
        final GridQueryCancel cancel,
        final Object[] params,
        final int[] parts
    ) {

But I decided that it would be better to replace the 3 parameters 
(timeoutMillis, maxFetchSize, prefetchSize) with  one:
private Iterable<List<?>> runQueryTwoStep(
        final String schemaName,
        final GridCacheTwoStepQuery qry,
        final boolean keepCacheObj,
        final boolean enforceJoinOrder,
        final SqlFieldsQuery sqlFieldsQry,
        final GridQueryCancel cancel,
        final Object[] params,
        final int[] parts
    ) {


> Need to set IGNITE_SQL_MERGE_TABLE_MAX_SIZE on per query basis
> --------------------------------------------------------------
>
>                 Key: IGNITE-5468
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5468
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Yakov Zhdanov
>            Assignee: Vitaliy Biryukov 
>            Priority: Critical
>             Fix For: 2.1
>
>
> Currently this property can be set via sys property only thus changing it 
> will require restart of the cluster. I think it is better to set it on 
> perquery basis with some default that is configured via cache configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to