[ 
https://issues.apache.org/jira/browse/IGNITE-5126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110755#comment-16110755
 ] 

Vladimir Ozerov commented on IGNITE-5126:
-----------------------------------------

[~tledkov-gridgain], my comments:
1) {{JdbcThinBatchSelfTest}} is not associated with any test suite.
2) {{JdbcQuery}} - missing {{toString}}
3) {{JdbcThinTcpIo.QUERY_BATCH_EXEC_MSG_INIT_CAP}} - strange heuristic. I would 
rather take {{QUERY_EXEC_MSG_INIT_CAP * QUERY_COUNT}}
4 {{JdbcThinTcpIo.batchExecute}} - why do we copying queries from list to 
array? We can simply use list in all places, it's not that better than array in 
context of this task. Same goes for batch arguments - why do we copy them over 
and over again?
5) Why does {{org.apache.ignite.internal.jdbc.thin.JdbcThinStatement#execute0}} 
clears the batch? Is it specified anywhere that calls to methods like 
{{executeQuery}} or {{executeUpdate}} must clear the batch?

>  JDBC thin driver: support batches
> ----------------------------------
>
>                 Key: IGNITE-5126
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5126
>             Project: Ignite
>          Issue Type: New Feature
>          Components: jdbc
>    Affects Versions: 1.9
>            Reporter: Taras Ledkov
>            Assignee: Taras Ledkov
>             Fix For: 2.2
>
>
> Support batches operations for the thin JDBC driver.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to