[ 
https://issues.apache.org/jira/browse/IGNITE-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132994#comment-16132994
 ] 

Taras Ledkov commented on IGNITE-4643:
--------------------------------------

[~ilyak], looks good. My comments:
1. Code style: if / for braces for multi-line statements.
2. I think we have to create separate ticket to enhance DatabaseMetadata for 
jdbc2 (or fix the comments below in this ticket):
2.1. Works with schema name is invalid. {{cacheName != schemaName}}. see 
{{JdbcRequestHandler#getSchemas}}
2.3. {{calatog}} parameter is ignored in all method. An empty results must be 
returned when non=empty catalog argument is passed.
2.4. Uppercase mustn't use on match & results output.

> JdbcDatabaseMetadata.getIndexInfo() method not working
> ------------------------------------------------------
>
>                 Key: IGNITE-4643
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4643
>             Project: Ignite
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.8
>            Reporter: Valentin Kulichenko
>            Assignee: Ilya Kasnacheev
>             Fix For: 2.2
>
>
> {{JdbcDatabaseMetadata.getIndexInfo()}} method does not update metadata 
> before creating result set. So if it's a first method invocation on this 
> instance of {{JdbcDatabaseMetadata}}, it fails with NPE. Need to create tests 
> and add {{updateMetaData()}} call in the beginning of the method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to