[ 
https://issues.apache.org/jira/browse/IGNITE-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134847#comment-16134847
 ] 

Vladimir Ozerov commented on IGNITE-4643:
-----------------------------------------

[~ilyak], my comments:
1) Changes to {{getDatabase*Version}} looks invalid to me. This method should 
return version of the database, which could differ from version of the driver. 
All changes to {{version}} methods should be reverted and implemented in a 
separate ticket.
2) I do not understand why {{matches}} method does upper-case conversions. 
{{MYTABLE}} and {{MyTable}} are different objects, but both will fall into same 
patterns.
3) As Taras mentioned, catalog is currently handled incorrectly. 

Provided that we have a range of problems here, and most of them are fixed 
incorrectly, I propose to focus on actual goal of the ticket - fix 
{{getIndexedInfo}} - this is one-line fix. The rest problems should be fixed 
separately.

> JdbcDatabaseMetadata.getIndexInfo() method not working
> ------------------------------------------------------
>
>                 Key: IGNITE-4643
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4643
>             Project: Ignite
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.8
>            Reporter: Valentin Kulichenko
>            Assignee: Ilya Kasnacheev
>             Fix For: 2.2
>
>
> {{JdbcDatabaseMetadata.getIndexInfo()}} method does not update metadata 
> before creating result set. So if it's a first method invocation on this 
> instance of {{JdbcDatabaseMetadata}}, it fails with NPE. Need to create tests 
> and add {{updateMetaData()}} call in the beginning of the method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to