[
https://issues.apache.org/jira/browse/IGNITE-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298370#comment-16298370
]
Vladimir Ozerov commented on IGNITE-4192:
-----------------------------------------
[~al.psc], my comments:
1) ConnectionPropertiesImpl.nestedTxMode - remove anonymous class, talk to
@tledkov on how to do this properly (as we removing another anonymous class in
{{host}} property in master)
2) JdbcConnectionContext.initializeFromHandshake - invalid TX mode should cause
exception and connection abort, not warning. Need to add test for this.
3) JdbcBatchExecuteRequest.ctor - {{autoCommit}} is not used. Need to add tests
for this.
4) GridQueryProcessor.querySqlFieldsNoCache - why do we need this change (null
as last argument?). As I see it changes nothing.
5) GridReduceQueryExecutor - pleas consult to Igor Selivaerstov about this
change, I am not sure it is correct.
6) IgniteH2Indexing.tryQueryDistributedSqlFieldsNative - looks wrong to me.
Transaction should be started only for BEGIN command. It should never be opened
for DDL, ROLLBACK and COMMIT.
7) IgniteH2Indexing.tryQueryDistributedSqlFieldsNative - let's move code
performaing TX commands into separate method for the sake of simplicity
8) IgniteH2Indexing.txStart - yesterday we finally agreed with Igor that it is
better to use intrnal API rather than public to start transactions. See
implicit transactions in DmlProcessor for reference. Let's factor out common
methods for TX start/commit/rollback/get and re-use this logic.
> SQL TX: JDBC driver support
> ---------------------------
>
> Key: IGNITE-4192
> URL: https://issues.apache.org/jira/browse/IGNITE-4192
> Project: Ignite
> Issue Type: Task
> Components: jdbc, sql
> Reporter: Denis Magda
> Assignee: Alexander Paschenko
> Labels: iep-3
> Fix For: 2.4
>
>
> To support execution of DML and SELECT statements inside of a transaction
> started from JDBC driver side.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
