[
https://issues.apache.org/jira/browse/IGNITE-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320924#comment-16320924
]
Oleg Ignatenko commented on IGNITE-6899:
----------------------------------------
I copied this branch to my machine and did a couple of brief checks. Overall,
so far so good (though I am not 100% done yet).
- I checked builds of ml module and examples from command line, these went
smoothly (my builds were without tests and javadocs though).
- Run examples (from IDEA), all executed smoothly: HelloWorld, Movie (with
{{-DGENRES=Action,Comedy,Romance}}), OptimizeMakeChange (with
{{-DAMOUNTCHANGE=75}}).
- Briefly studied examples code. In examples pom, ignite-ml dependency outside
of ml profile looks superfluous but that's minor. Wrt java code of examples,
good news are that it loos clear and easy to understand, just the kind code I'd
want to see when learning new API. Very well done. Bad news are, there are
multiple deviations from [coding style guidelines of
Ignite|https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines], I
am not even sure if it can pass javadocs check at Teamcity. These issues look
manageable though and given that examples code is so apparently useful I would
strongly recommend to put an effort into onboarding it to the project.
- Run unit tests (GAGridTestSuite, in IDEA) - all passed.
- Run coverage analysis of unit tests (report attached: [^coverage.zip]). Per
cursory glance, coverage looks reasonably okay - similar or better to that in
most other ml packages. It's not as good as that of math package but as far as
I know improving unit tests coverage in whole ml module is planned as dedicated
effort anyway so it's probably good enough for now.
-----
Above are first brief observations. Further I plan to closer study code added
in {{genetic}} packages in ml module, under both main and test and check
[documentation at
readme.io|https://apacheignite.readme.io/v2.3/docs/genetic-algorithms]. I am
going to continue posting additional observations and considerations here.
> Adding GA Grid to Apache Ignite ML module.
> ------------------------------------------
>
> Key: IGNITE-6899
> URL: https://issues.apache.org/jira/browse/IGNITE-6899
> Project: Ignite
> Issue Type: New Feature
> Components: ml
> Reporter: Yury Babak
> Assignee: Turik Campbell
> Fix For: 2.4
>
> Attachments: coverage.zip
>
>
> We want to add GA Grid to our ML Module.
> This is the first iteration of this integration. On this step we will simple
> add GA Grid to the separate package in ML module.
> (i) This is a good package for GA Grid: org.apache.ignite.ml.genetic
> (i) For GA Grid we need unit tests as well as examples
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
