[
https://issues.apache.org/jira/browse/IGNITE-6842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369470#comment-16369470
]
ASF GitHub Bot commented on IGNITE-6842:
----------------------------------------
GitHub user Mmuzaf opened a pull request:
https://github.com/apache/ignite/pull/3542
IGNITE-6842
Test PR for learning contributing processes.
- Remove duplicated code stopGrid methods;
- Add stopAllGridsSilently method throwing exception in case stop grids
fails;
- Make stopGrids default behavior for afterTestsStopped;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Mmuzaf/ignite ignite-6842
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/3542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3542
----
commit 40f9c158e226942a02a22673637e593a28096496
Author: Maxim Muzafarov <maxmuzaf@...>
Date: 2018-02-18T14:29:55Z
IGNITE-6842: make stopAllGrids as default behavior for afterTestsStop
commit 18248091903a0d44e292eb2502f0c40a18abd3cd
Author: Maxim Muzafarov <maxmuzaf@...>
Date: 2018-02-19T09:25:52Z
IGNITE-6842:add stopAllGridsSilently as default stop grid
commit b18d9aadc6613c9f5c48e7b2cec2b53ed385c994
Author: Maxim Muzafarov <maxmuzaf@...>
Date: 2018-02-19T09:26:21Z
Merge branch 'master' of https://github.com/apache/ignite into ignite-6842
----
> Stop all nodes after test by default.
> -------------------------------------
>
> Key: IGNITE-6842
> URL: https://issues.apache.org/jira/browse/IGNITE-6842
> Project: Ignite
> Issue Type: Improvement
> Reporter: Alexei Scherbakov
> Assignee: Maxim Muzafarov
> Priority: Major
> Labels: newbie
> Fix For: 2.5
>
>
> Currently it's required to manually call stopAllGrids() after test completion.
> This leads to errors in subsequent tests if someone forgets to call it and to
> additional boilerplate code in tests.
> Right choice is to make this default behavior.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
