[
https://issues.apache.org/jira/browse/IGNITE-6842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409388#comment-16409388
]
Nikolay Izhikov commented on IGNITE-6842:
-----------------------------------------
[~avinogradov], [~daradurvs], [~Mmuzaf]
Guys, I think we have some misunderstanding here.
That lead to inconsistent edits in this PR.
Can you clarify it to me.
1. We have constructor {{GridAbstractTest(boolean startGrid)}}. On who use that
constructor told to test framework: "Please, start some default grid *before*
my tests started so I can setup that grid to use in tests".
2. We have method {{beforeTestsStarted}}. But we don't have default grid
started in that method! Because {{startGrid}} analyzed after
{{beforeTestsStarted}} execution.
I think we has to check that
> 1) We have to assert that there is no alive nodes at
> -GridAbstractTest'sbeforeTestsStarted- {{setUp}} and start default node if
> {{startGrid=true}} before {{beforeTestsStarted}} execution.
It works like that in current master.
> 2) We have to kill all alive nodes (without force) at
> -GridAbstractTest'safterTestsStopped - {{tearDown}}, but *AFTER*
> {{GridAbstractTest'safterTestsStopped}} execution so test author can
> implement some post-test logic based on alive nodes state.
> Stop all nodes after test by default.
> -------------------------------------
>
> Key: IGNITE-6842
> URL: https://issues.apache.org/jira/browse/IGNITE-6842
> Project: Ignite
> Issue Type: Improvement
> Reporter: Alexei Scherbakov
> Assignee: Maxim Muzafarov
> Priority: Major
> Labels: newbie
> Fix For: 2.5
>
> Attachments: IgniteStopGridsTestSuite.java,
> StopGridsStateFirstTest.java, StopGridsStateSecondTest.java
>
>
> Currently it's required to manually call stopAllGrids() after test completion.
> This leads to errors in subsequent tests if someone forgets to call it and to
> additional boilerplate code in tests.
> Right choice is to make this default behavior.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
