[ 
https://issues.apache.org/jira/browse/IGNITE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490851#comment-16490851
 ] 

ASF GitHub Bot commented on IGNITE-8293:
----------------------------------------

GitHub user agura opened a pull request:

    https://github.com/apache/ignite/pull/4074

    IGNITE-8293 BinaryUtils#isCustomJavaSerialization fails when only 
readObject is declared in a class

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agura/incubator-ignite ignite-8293

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4074.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4074
    
----
commit 726e90e0f33ab446a8b41c118789ab450f464588
Author: Mihkel Jõhvik <mihkel.johvik@...>
Date:   2018-05-02T07:30:59Z

    IGNITE-8293 BinaryUtils#isCustomJavaSerialization fails when only 
readObject is declared in a class

----


> BinaryUtils#isCustomJavaSerialization fails when only readObject is declared 
> in a class
> ---------------------------------------------------------------------------------------
>
>                 Key: IGNITE-8293
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8293
>             Project: Ignite
>          Issue Type: Bug
>          Components: binary
>    Affects Versions: 2.4
>            Reporter: MihkelJ
>            Assignee: MihkelJ
>            Priority: Minor
>             Fix For: 2.6
>
>         Attachments: IGNITE-8293.patch
>
>
> Consider this class:
>  
> {code:java}
> public class Test implements Serializable {
>     private transient AtomicBoolean dirty = new AtomicBoolean(false);
>     private void readObject(java.io.ObjectInputStream in) throws IOException, 
> ClassNotFoundException {
>         dirty = new AtomicBoolean(false);
>     }
>     //methods to check and mark class as dirty
> }{code}
> {{isCustomJavaSerialization}} will get a {{NoSuchMethodException}} when 
> trying to grab the {{writeObject}} method and falsely conclude that Test 
> doesn't use custom serialization.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to