[
https://issues.apache.org/jira/browse/IGNITE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493947#comment-16493947
]
Andrey Gura commented on IGNITE-8293:
-------------------------------------
[~MihkelJ], I've reviewed your patch and have a comment:
{{BinaryUtilsIsCustomSerializationTest}} doesn't contains Apache 2.0 license
header and javadocs. Also this test uses JUnit 4 while we still use JUnit 3.
Test is ok, but it isn't related with binary marshaller. I think it would be
great if you remove your tests and add test cases to
{{BinaryMarshallerSelfTest}}. Use existing test cases as examples. Is there any
chance that you fix this comment?
> BinaryUtils#isCustomJavaSerialization fails when only readObject is declared
> in a class
> ---------------------------------------------------------------------------------------
>
> Key: IGNITE-8293
> URL: https://issues.apache.org/jira/browse/IGNITE-8293
> Project: Ignite
> Issue Type: Bug
> Components: binary
> Affects Versions: 2.4
> Reporter: MihkelJ
> Assignee: MihkelJ
> Priority: Minor
> Fix For: 2.6
>
> Attachments: IGNITE-8293.patch
>
>
> Consider this class:
>
> {code:java}
> public class Test implements Serializable {
> private transient AtomicBoolean dirty = new AtomicBoolean(false);
> private void readObject(java.io.ObjectInputStream in) throws IOException,
> ClassNotFoundException {
> dirty = new AtomicBoolean(false);
> }
> //methods to check and mark class as dirty
> }{code}
> {{isCustomJavaSerialization}} will get a {{NoSuchMethodException}} when
> trying to grab the {{writeObject}} method and falsely conclude that Test
> doesn't use custom serialization.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
