[
https://issues.apache.org/jira/browse/IGNITE-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547847#comment-16547847
]
Sergey Chugunov commented on IGNITE-8188:
-----------------------------------------
[~NSAmelchev],
Overall improvement looks good to me as well but I left minor comment in
UpSource.
Also method *ZkDistributedCollectDataFuture#deleteFutureData* still has a catch
block for NoNodeException: I think it should be removed as *deleteAll* won't
throw it anymore.
Lets fix these comments, check TC and merge the change if everything is OK.
> Batching operations should perform check for ZooKeeper request max size
> -----------------------------------------------------------------------
>
> Key: IGNITE-8188
> URL: https://issues.apache.org/jira/browse/IGNITE-8188
> Project: Ignite
> Issue Type: Improvement
> Components: zookeeper
> Reporter: Sergey Chugunov
> Assignee: Amelchev Nikita
> Priority: Major
> Fix For: 2.7
>
>
> As ZooKeeper documentation
> [says|https://zookeeper.apache.org/doc/r3.4.3/api/org/apache/zookeeper/ZooKeeper.html#multi(java.lang.Iterable)]
> batching *multi* operation has a limit for size of a single request.
> ZookeeperClient batching methods *createAll* and *deleteAll* should check
> this limit and fall back to execute operations one by one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
