[ 
https://issues.apache.org/jira/browse/IGNITE-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548944#comment-16548944
 ] 

Amelchev Nikita commented on IGNITE-8188:
-----------------------------------------

[~sergey-chugunov], Thank for your comments. 

I have fixed PR and ran [tests on TC 
again|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&branch_IgniteTests24Java8=pull%2F4236%2Fhead].
 One test failed 
_ZookeeperDiscoverySpiTest.testCommunicationFailureResolve_CachesInfo1_ and it 
isn't my changes fail by the log. Local test run OK. 

Could you review?

> Batching operations should perform check for ZooKeeper request max size
> -----------------------------------------------------------------------
>
>                 Key: IGNITE-8188
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8188
>             Project: Ignite
>          Issue Type: Improvement
>          Components: zookeeper
>            Reporter: Sergey Chugunov
>            Assignee: Amelchev Nikita
>            Priority: Major
>             Fix For: 2.7
>
>
> As ZooKeeper documentation 
> [says|https://zookeeper.apache.org/doc/r3.4.3/api/org/apache/zookeeper/ZooKeeper.html#multi(java.lang.Iterable)]
>  batching *multi* operation has a limit for size of a single request.
> ZookeeperClient batching methods *createAll* and *deleteAll* should check 
> this limit and fall back to execute operations one by one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to