[
https://issues.apache.org/jira/browse/IGNITE-9272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586490#comment-16586490
]
Dmitriy Setrakyan commented on IGNITE-9272:
-------------------------------------------
Can we add this option without breaking compatibility with previous
page/storage formats? If not, then this should support both implementation. The
default should be the new fastest implementation, but if we encounter the
older, slower one, then we should print out a warning in the log and
automatically switch to the older implementation.
> PureJavaCrc32 vs j.u.zip.CRC32 benchmark and probably replace.
> --------------------------------------------------------------
>
> Key: IGNITE-9272
> URL: https://issues.apache.org/jira/browse/IGNITE-9272
> Project: Ignite
> Issue Type: Improvement
> Components: general
> Affects Versions: 2.6
> Reporter: Stanilovsky Evgeny
> Assignee: Stanilovsky Evgeny
> Priority: Major
> Fix For: 3.0
>
> Attachments: BenchmarkCRC.java
>
>
> I see that Ignite has its own crc32 realization called: PureJavaCrc32 and
> from desc it seems to be : _The current version is ~10x to 1.8x as fast as
> Sun's native java.util.zip.CRC32 in Java 1.6_ But my jmh tests show opposite
> results.
> + If it really so, looks like backward compatibility would be easy, all that
> need is just to take lower part of long form zip.crc32 realization.
> jmh results:
> Benchmark Mode Cnt Score Error Units
> BenchmarkCRC.Crc32 avgt 5 1521060.716 ± 44083.424 ns/op
> BenchmarkCRC.pureJavaCrc32 avgt 5 4657756.671 ± 177243.254 ns/op
> JMH version: 1.21
> VM version: JDK 1.8.0_131, Java HotSpot(TM) 64-Bit Server VM, 25.131-b11
> VM invoker: /usr/lib/jvm/java-8-oracle/jre/bin/java
> op system : ubuntu 16.10
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
